Database validation #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sakari-malkki
force-pushed
the
feature/database-validation
branch
from
aee96d6 to
b9b8327
Compare
jsaarimaa
reviewed
Sep 12, 2024
jsaarimaa
reviewed
Sep 12, 2024
Px.Utils/Validation/ContentValidation/ContentValidator.UtilityMethods.cs
Outdated
Show resolved
Hide resolved
jsaarimaa
reviewed
Sep 13, 2024
…coding if it is not provided explicitly
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
Px.Utils/Validation/ContentValidation/ContentValidator.UtilityMethods.cs
Outdated
Show resolved
Hide resolved
jsaarimaa
reviewed
Sep 13, 2024
Px.Utils/Validation/ContentValidation/ContentValidator.ValidationFunctions.cs
Outdated
Show resolved
Hide resolved
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
Px.Utils.UnitTests/Validation/DatabaseValidation/DatabaseValidatorTests.cs
Outdated
Show resolved
Hide resolved
jsaarimaa
reviewed
Sep 13, 2024
Px.Utils.UnitTests/Validation/DatabaseValidation/DatabaseValidatorTests.cs
Show resolved
Hide resolved
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
Px.Utils/Validation/SyntaxValidation/SyntaxValidationFunctions.cs
Outdated
Show resolved
Hide resolved
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
reviewed
Sep 13, 2024
jsaarimaa
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database validation feature.
DatabaseValidator class contains blocking and async methods for validating a database based on a given directory path.
Validation functions are found in DatabaseValidatorFunctions.cs.
IFileSystem interface and its implementations DefaultFileSystem and MockFileSystem were created in order to be able to test DatabaseValidator functionality by mocking the IO operations.
Readme updated to include the new feature.
Benchmark added for both validation methods.
Benchmarking the StatFin database with both asynchornous and blocking methods takes about 1.5 minutes.